Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][ETCD] Lens migration for visualizations to Kibana version 8.3.0 #5545

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[O11y][ETCD] Lens migration for visualizations to Kibana version 8.3.0 #5545

merged 3 commits into from
Mar 21, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for ETCD integration package

  • Statistics for ETCD Lens migration:

ETCD Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics etcd] Overview 0 8 7 0
  0 8 7 0

Note: One visualization is migrated to new input controls.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 15, 2023 12:44
@kush-elastic kush-elastic mentioned this pull request Mar 15, 2023
Closed
5 tasks
@kush-elastic kush-elastic added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team v8.3.0 labels Mar 15, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T06:30:11.704+0000

  • Duration: 15 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 64.286% (9/14) 👎 -34.719
Lines 100.0% (0/0) 💚 5.803
Conditionals 100.0% (0/0) 💚

kush-elastic
kush-elastic approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 935994f into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package etcd - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=etcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@rameshelastic rameshelastic Awaiting requested review from rameshelastic

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:etcd etcd Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajvi-patel-22 @elasticmachine @kush-elastic @agithomas